Skip to content

Implement clustered tables' options in Meta: number_of_shards and clustered_by #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2025
Merged

Implement clustered tables' options in Meta: number_of_shards and clustered_by #22

merged 2 commits into from
Nov 10, 2025

Conversation

@surister
Copy link
Member

@surister surister commented Nov 6, 2025 •
edited
Loading

Summary of the changes / Why this is an improvement

Implements clustered options for CrateDB models.

Example:

    class MetaOptions(CrateModel):
        id = models.IntegerField()
        one = models.TextField()
        two = models.TextField()
        three = models.TextField()

        class Meta:
            app_label = "ignore"
            clustered_by = "one"
            number_of_shards = 3

Checklist

@surister surister requested a review from amotl November 7, 2025 08:33
amotl
amotl approved these changes Nov 9, 2025
View reviewed changes
Copy link
Member

@amotl amotl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

cratedb_django/models/model.py
Comment on lines -52 to +55
if auto_refresh and self.pk: # If self.pk is available, its an insert.
if auto_refresh and self.pk: # If self.pk is available, it's an insert.
Copy link
Member

@amotl amotl Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the dataflow, architecture, and program data model of the Django ORM, so please don't consider this to be valid question: It's just a curious one.

Couldn't a record including a primary key also be an UPDATE operation?

Copy link
Member Author

@surister surister Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so, yeah, the comment is not 'complete'

@surister surister force-pushed the feat/clustered_tables branch from 96fae6f to 17b92c9 Compare November 10, 2025 09:41
@surister surister force-pushed the feat/clustered_tables branch from 1f81929 to da6f1f1 Compare November 10, 2025 09:43
@surister surister merged commit 2657622 into master Nov 10, 2025
2 checks passed
@surister surister deleted the feat/clustered_tables branch November 10, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amotl amotl amotl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement clustered_by in class meta options

3 participants

@surister @amotl